-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only create fake divs for <input>
fields that have text containing types
#1117
Comments
List of
Keep:
Safe to ignore:
Thoughts? |
(Recommending https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input over w3schools but mostly just preference) Others to think about: I think it's okay to pick the ones that can be directly used and ignore the rest. In that case, maybe just add |
Woah! I didn't know non-ascii emails was a thing! Also, good catch on the submit. I did a bit of searching and found some info that mentions it but have never seen something like that. Crazy. Snippet from RFC6539
|
More than that though, I think we should limit the types of inputs we try to extract text from. It was originally added when
<input>
was just text but now it can be things like range, date, and number which aren't useful to try to get Japanese text from. We should probably add a allowlist for input types which rikaikun tries to process since it's a waste of cycles if nothing else!Let's leave this bug for properly cleaning up the added
<input>
sOriginally posted by @melink14 in #1114 (comment)
Some decisions:
The text was updated successfully, but these errors were encountered: