Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to tokio 1.0 #79

Closed
abour opened this issue Jan 3, 2021 · 3 comments · Fixed by #81
Closed

Update to tokio 1.0 #79

abour opened this issue Jan 3, 2021 · 3 comments · Fixed by #81

Comments

@abour
Copy link

abour commented Jan 3, 2021 •
edited

Reqwest is now using tokio 1.0 (seanmonstar/reqwest#1076 was merged), so I think the update could be done now ?

EDIT: Actually I just figured out that even if it has been merged into master, not tag were added.
@curquiza
Copy link
Member

curquiza commented Jan 4, 2021

Hello @abour!
Feel free to open a PR when the tag will be added then 😁

@Mubelotix
Copy link
Collaborator

It is not necessary since this crate will not use reqwest anymore in the next versions.

@Mubelotix Mubelotix linked a pull request Jan 4, 2021 that will close this issue
Remove tokio #81
Merged
@abour
Copy link
Author

abour commented Jan 5, 2021

Ok thank you good to know !

@curquiza curquiza closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove tokio meilisearch/meilisearch-rust
3 participants
@abour @curquiza @Mubelotix