Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a custom user-agent for Node users. #1437

Open
brunoocasali opened this issue Jan 12, 2023 · 2 comments · May be fixed by #1595
Open

Add a custom user-agent for Node users. #1437

brunoocasali opened this issue Jan 12, 2023 · 2 comments · May be fixed by #1595
Labels
enhancement New feature or request

Comments

@brunoocasali
Copy link
Member

The idea is to send a new Meilisearch Node (v0.0.0) alongside the current user agents when the user requests on the backend side.

I think there are valuable insights if we could differentiate those metrics.
@brunoocasali brunoocasali added the enhancement New feature or request label Jan 12, 2023
@FroostyCodes
Copy link

Hi @brunoocasali can you let me know if this is still be done?

@brunoocasali
Copy link
Member Author

Yes, go ahead as far as I remember we still have the same user agent for both!

@Botseer Botseer linked a pull request Oct 27, 2023 that will close this issue
Open
3 tasks
meili-bors bot added a commit that referenced this issue Oct 31, 2023
@meili-bors @Botseer
Merge #1595
ec84e24 
1595: refactor: update clients to have different user agents r=brunoocasali a=Botseer

# Pull Request

## Related issue
Fixes #1437

## What does this PR do?
The users agents for BrowserClient and NodeClient have been differentiated as per the issue for better metrics.

As for the code changes, I have made the change such that the necessary user agents are provided while constructing the respective client itself. Therefore there is no need to handle user agents in the `http-request` file.

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Botseer <homeu99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update clients to have different user agents Botseer/meilisearch-js
2 participants
@brunoocasali @FroostyCodes