refactor: update clients to have different user agents #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brunoocasali Please review this PR 🙏 |
brunoocasali
previously approved these changes
Oct 31, 2023
meili-bors bot
added a commit
that referenced
this pull request
Oct 31, 2023
1595: refactor: update clients to have different user agents r=brunoocasali a=Botseer # Pull Request ## Related issue Fixes #1437 ## What does this PR do? The users agents for BrowserClient and NodeClient have been differentiated as per the issue for better metrics. As for the code changes, I have made the change such that the necessary user agents are provided while constructing the respective client itself. Therefore there is no need to handle user agents in the `http-request` file. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Botseer <homeu99@gmail.com>
|
Build failed: |
|
@brunoocasali please do review again, sorry previously it seems I missed the tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1595 +/- ##
==========================================
- Coverage 97.43% 97.31% -0.12%
==========================================
Files 22 22
Lines 858 857 -1
Branches 93 87 -6
==========================================
- Hits 836 834 -2
Misses 22 22
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
|
Hey @Botseer, sorry for the late reply, but can you check why the coverage dropped? |
flevi29
reviewed
May 23, 2024
| ...config, | ||
| clientAgents: [ | ||
| ...(config.clientAgents ?? []), | ||
| `Meilisearch Node (v${PACKAGE_VERSION})`, |
There was a problem hiding this comment.
Considering that this package might be used by any other runtime like Deno and Bun and more, does it make sense to call it Node? Maybe it would be best if we'd only ship one client, one that runs everywhere, and is a lot more treeshakeable, but that's part of another issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #1437
What does this PR do?
The users agents for BrowserClient and NodeClient have been differentiated as per the issue for better metrics.
As for the code changes, I have made the change such that the necessary user agents are provided while constructing the respective client itself. Therefore there is no need to handle user agents in the
http-requestfile.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!