Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid updating the version of the local packages in the playgrounds #1059

Open
bidoubiwa opened this issue Apr 4, 2023 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bidoubiwa
Copy link
Contributor

Currently, when updating the version of a package, changeset also updates the version of the package in the apps which depends on it. For example:

if instant-meilisearch version is:
https://github.com/meilisearch/instant-meilisearch/blob/004a4989c9febaf60fcb357f576b9776736d7959/packages/instant-meilisearch/package.json#L2-L3

The associated version in any playground is the same:
https://github.com/meilisearch/instant-meilisearch/blob/004a4989c9febaf60fcb357f576b9776736d7959/playgrounds/javascript/package.json#L20-L22

Nonetheless as per the turborepo documentation on Workspaces which depend on each other

To use a workspace inside another workspace, you'll need to specify it as a dependency, using its name.

For instance, if we want apps/docs to import packages/shared-utils, we'd need to add shared-utils as a dependency inside apps/docs/package.json:

```
{
  "dependencies": {
    "shared-utils": "*"
  }
}
```

The * allows us to reference the latest version of the dependency. It saves us from needing to bump the versions of our dependency if the versions of our packages change.

The last part is what is relevant to us

The * allows us to reference the latest version of the dependency. It saves us from needing to bump the versions of our dependency if the versions of our packages change.

Solution

We use changeset to handle versionning.
We need to find a way to configure changeset in order to leave the playgrounds versions of the local packages to *.

For example:

  • I update @meilisearch/instant-meilisearch to v1
  • In the packages.json of the javascript playground, the version of @meilisearch/instant-meilisearch should remain a wild card.
"dependencies": {
    "@meilisearch/instant-meilisearch": "*"
  }
@bidoubiwa bidoubiwa added the enhancement New feature or request label Apr 4, 2023
@bidoubiwa bidoubiwa added the good first issue Good for newcomers label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant