0.13.x: Backport #362 #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch reverts the matrix for the clippy job to only run clippy on our MSRV instead of stable, beta and nightly. The recurring issue with this was that lints started failing in PRs that couldn't have been fixed in master yet, because master was never tested with a clippy that new (in case of nightly). 1.56.1 is good enough for now. Signed-off-by: Matthias Beyer <mail@beyermatthias.de> (cherry picked from commit 336a34e)
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> (cherry picked from commit d54986c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #362 ("Run clippy only on MSRV") to the
release-0.13.xbranch.With the
0.13.2release, clippy fails because of this. Port back the changes from #362 so that in our next patch release (if it happens), this does not break again.