"Prisma server not ready" version 3.1.1+

[blopker]

Hello! I wanted to surface an issue I ran in to while following the Getting Started guide. After following the guide, then running the final dart program to add a user to the database, I'm getting this error:

~/code/dartprisma/hello main*
❯ dart run
Building package executable...
Built hello:hello.
Hello world: Instance of 'Future<dynamic>'!
quaint::pooled: Starting a postgresql pool with 21 connections. - 2023-03-14 19:35:39.490859Z
Unhandled exception:
PrismaInitializationException: Prisma server is not ready
#0      BinaryEngine._waitPrismaServerReady.<anonymous closure> (package:orm/binary_engine.dart:255:7)
#1      RetryOptions.retry (package:retry/retry.dart:138:24)
<asynchronous suspension>
#2      BinaryEngine._createProcess (package:orm/binary_engine.dart:190:19)
<asynchronous suspension>
#3      BinaryEngine.start (package:orm/binary_engine.dart:149:17)
<asynchronous suspension>
#4      UniversalEngine.request (package:orm/universal_engine.dart:59:5)
<asynchronous suspension>
#5      ModelDelegate._execute (package:orm/src/client/model_delegate.dart:37:20)
<asynchronous suspension>
#6      PrismaFluent.queryBuilder.<anonymous closure> (package:orm/src/client/prisma_fluent.dart:37:22)
<asynchronous suspension>

This error does not happen on version 3.1.0, but starts happening on version 3.1.1 and still happens on 3.1.2. Anything can be done about that?

[medz]

I guess, we should just do more accurate error output.

I have, I will look into this and let you know.

[medz]

@blopker Can you provide a minimal example where this error occurs? It is best to create a repository.

[blopker]

I really just followed the guide at https://prisma.pub/docs/getting-started.html. The code is the same.

I looked at it a bit and added a delay in binary_engine, and it started working:

    return retry<bool>(() async {
      await Future.delayed(Duration(seconds: 1));
      final response = await http.get(url);

It looks like the retry logic isn't looping correctly, and the server isn't starting up fast enough on my system. I'd suggest changing the retry logic to:

return retry<bool>(() async {
      final response = await http.get(url);
      if (response.statusCode == 200) {
        final json = convert.json.decode(response.body);
        if (json['status'].toString().toLowerCase() == 'ok') return true;
      }
      throw PrismaInitializationException(
          message: 'Prisma server is not ready', engine: this);
    });

Instead of throwing the exception in the onRetry callback.

[medz]

@blopker Fixed in v3.1.3 version, Thanks again.

[blopker]

Nice! Thanks for the quick turnaround. Hopefully the Prisma people get that C API you wanted done and then there will be none of this server business to deal with.

[medz]

Nice! Thanks for the quick turnaround. Hopefully the Prisma people get that C API you wanted done and then there will be none of this server business to deal with.

I'm a Rust Apprentice, and I'm overwhelmed by upstream breaking changes.

Issue flagged at prisma/prisma-engines#3757. But Prisma officials seem to be very busy, all I can do is wait.

Maybe someday I'll create a PR for them when I feel competent enough to edit the Prisma engine's Rust code. This is great for me, since bringing Prisma into Flutter has always been a goal of mine.

[blopker]

Hm, the fix didn't quite work. It looks like the http library is throwing an exception when the server isn't up yet. I think the code needs to retry on any exception.

[medz]

Hm, the fix didn't quite work. It looks like the http library is throwing an exception when the server isn't up yet. I think the code needs to retry on any exception.

I found it too, I'll re-fix it

[medz]

@blopker Because I paid one-sided attention to the abnormal retry of the function body before, and ignored the IO related, now I fixed it in v3.1.4 👉https://github.com/odroe/prisma-dart/releases/tag/orm-v3.1.4

[blopker]

Works now! Thanks @medz. Another thing I noticed is that if _waitPrismaServerReady does fail, but the server does start, the Process object that's created doesn't get cleaned up. When I was testing I had a dozen or so servers running without a parent. I think adding a kill in _createProcess if things go sideways might be good:

    // Wait for ready.
    if (await _waitPrismaServerReady()) {
      return process;
    }
   process.kill();

It's cool you're working on this. There's not really a good solution to database management for Dart yet. This is going to be a huge win for this ecosystem. I was under the impression Prisma re-wrote the server in Rust specifically to support more languages, but I guess they never got that far.