Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error running serverless-webpack on Windows since recent Node JS security update #2

Open
massimocode opened this issue May 16, 2024 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@massimocode
Copy link

massimocode commented May 16, 2024

Please see the following:
serverless/serverless#12434

Also this Node JS issue discussing the security change:
nodejs/node#52554

It seems like adding a flag { shell: true } will resolve this

Thanks

@massimocode
Copy link
Author

I've raised this in serverless-webpack instead, as it seems they are the one who is trying to spawn a .cmd file. Feel free to close the issue if it's not the responsibility of this module.

@medikoo
Copy link
Owner

medikoo commented May 16, 2024

@massimocode cli-progress-footer just decorates spawn and returns the value as it is.

In this case native spawn crashes with EINVAL and cli-progress-footer behaves properly by exposing the crash without obstruction.

I believe the issue is in serverrless-webpack which probably tries to call npm.cmd (or other cmd program on windows) while this is no longer allowed with latest version of Node.js

@medikoo medikoo added the question Further information is requested label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants