feature: add query as object constructor and tests #367
Conversation
src/URI.js
Outdated
| if (hasOwn.call(this._parts, key)) { | ||
| this._parts[key] = src[key]; | ||
| } | ||
| } | ||
| this.query(src['query']); |
There was a problem hiding this comment.
this should probably only be executed if src.query is actually defined
There was a problem hiding this comment.
definitely! will update.
edit: should it be a test that fail in this case? all tests were passing anyway.
src/URI.js
Outdated
| for (key in src) { | ||
| if (key === 'query') { | ||
| hasQueryPart = true; |
There was a problem hiding this comment.
wait a second, this can be true even if src['query'] is undefined, isnt it?
maybe I should have changed it to
if (key === 'query' && src[key] !== undefined) {There was a problem hiding this comment.
you can keep the if (key === 'query') { continue; } part and add if (src.query) { this.query(src.query, false); }. you only need to execute .query() if there actually is a value (other than null, undefined, empty-string)
… value as a query
|
About fragments: I think we should open its own issue and solve it in its own PR. |
test/test.js
Outdated
| }); | ||
| ok(u instanceof URI, 'instanceof URI'); | ||
| ok(typeof u.query() === 'string', 'query is string'); | ||
| ok(u.query() === 'foo=bar&bar=foo', 'query has right value'); |
There was a problem hiding this comment.
equal(u.query(), 'foo=bar&bar=foo', 'query() value');
test/test.js
Outdated
| ok(typeof u.query() === 'string', 'query is string'); | ||
| ok(u.query() === 'foo=bar&bar=foo', 'query has right value'); | ||
| ok(u.search() === '?foo=bar&bar=foo', 'search has right value'); | ||
| ok(typeof u.query(true) === 'object', 'query map is object'); |
There was a problem hiding this comment.
deepEqual(u.query(true), { foo: 'bar', bar: 'foo' }, 'query(true) value');
fine by me :) |
|
thank you! |
|
You're welcome, looking forward to this being released! 👍 |
Attempt to resolve #366