Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.0.0b] - recipe-scraper v14.23.0 fixes importing on several websites #1834

Closed
5 tasks done
elliotmatson opened this issue Nov 16, 2022 · 2 comments · Fixed by #1835
Closed
5 tasks done

[v1.0.0b] - recipe-scraper v14.23.0 fixes importing on several websites #1834

elliotmatson opened this issue Nov 16, 2022 · 2 comments · Fixed by #1835

Comments

@elliotmatson
Copy link

First Check

  • This is not a feature request
  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.

What is the issue you are experiencing?

Attempting to import anything from Delish.com fails with the following debug message:
"recipe_scrapers was unable to scrape this URL"
This also fails on the demo site.
I tried just using the recipe-scrapers library by itself, and it seems to work fine

Deployment

Docker (Linux)

Deployment Details

No response

@elliotmatson
Copy link
Author

Just tried recipe-scrapers v14.20.0 that the current build of mealie uses, and it indeed fails. Looks like it was fixed in v14.23.0:
hhursev/recipe-scrapers/pull/676

@elliotmatson elliotmatson changed the title [v1.0.0b] - Delish.com importing fails in Mealie, works with recipe-scraper [v1.0.0b] - recipe-scraper v14.23.0 fixes importing on several websites Nov 16, 2022
@michael-genson
Copy link
Collaborator

Interestingly the newest version fails to pull in the picture, while the version we're on finds it fine.
Obviously it's much preferable to upgrade and get the recipe vs staying on the existing version and only getting the image, but I found that interesting.

Thanks for the report! I'll put in a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants