Update png dependency
#2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pngversion 0.11 is 5 years old now. It was minimal effort to update topngversion 0.17, and with it comes a few big performance improvements as far as I'm aware.I know this project is quite old but this project is also quite popular on crates.io with about 1k downloads a day and I see you're still active on GitHub so I figured making a PR was worth a shot.
All tests passed and the example ran without issues. I hope you can come back to this project for just a little bit as a few popular crates depend on this (like
Tauri) and Rust needs to compile bothpng0.17 andpng0.11 just for this crate :)