Fix issue when using --enable-frozen-string-literal Ruby option #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdp
added a commit
that referenced
this pull request
Apr 22, 2020
- Fix issue when using --enable-frozen-string-literal Ruby option #95 (jeremyevans) - Update gems (rake, addressable) - Updated gems removes support for Ruby <2.5. Seeing as 2.3 is now longer getting security patches, this seems like a non-issue
|
Thanks Jeremy, If you're OK with it, I'm moving this into a major version bump where I'm also updating the dependencies (which removed support for ruby <2.3, hence the major bump) If that all looks good, I'll push this out tonight or tomorrow. |
|
Sure, that sounds good to me. Thank you for the quick response! |
mdp
added a commit
that referenced
this pull request
Apr 23, 2020
- Version bump to 6.0.0 due to Ruby support change - Updated 'addressable' and 'rake' gems Squashed commit of the following: commit 95e4873 Author: Mark Percival <m@mdp.im> Date: Thu Apr 23 15:35:15 2020 +0000 Update Changelog about travis ruby addition commit f252777 Author: Mark Percival <m@mdp.im> Date: Wed Apr 22 17:47:03 2020 +0000 Major bump commit 191ef03 Author: Mark Percival <m@mdp.im> Date: Wed Apr 22 17:35:50 2020 +0000 Add back in 2.3 2.3 has been EOL'd, but it still compatible with this gems dependencies commit bafe8bf Author: Mark Percival <m@mdp.im> Date: Wed Apr 22 17:12:59 2020 +0000 Remove Travis ruby test for 2.0 commit 0919196 Author: Mark Percival <m@mdp.im> Date: Wed Apr 22 17:08:45 2020 +0000 Frozen string fix, updated deps, ruby deprecation - Fix issue when using --enable-frozen-string-literal Ruby option #95 (jeremyevans) - Update gems (rake, addressable) - Updated gems removes support for Ruby <2.5. Seeing as 2.3 is now longer getting security patches, this seems like a non-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.