Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/cssxref): use page-type to detect CSS Functions/Data Types #7729

Merged
merged 4 commits into from Dec 2, 2022

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Dec 2, 2022

Summary

Replace the use of tags in cssxref with the page type.

Problem

cssxref used tags: we would like to retire tags eventually, and this one is an easy fix since we already have page types for CSS.

Solution

Use page type!

How did you test this change?

Ran yarn dev and added an edit like:

It's a {{cssxref("sign")}} of the {{cssxref("time")}}s.

It's a {{cssxref("sign()")}} of the {{cssxref("<time>")}}s.

....which gave me:

Screen Shot 2022-12-01 at 8 07 54 PM

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Dec 2, 2022
@caugner caugner changed the title Remove tags from cssxref chore(macros/cssxref): use page-type to detect CSS Functions/Data Types Dec 2, 2022
@caugner caugner merged commit 2720d1f into mdn:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants