Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(macros/HTML): update zh-CN strings #6723

Merged
merged 1 commit into from
Jul 17, 2022
Merged

chore(macros/HTML): update zh-CN strings #6723

merged 1 commit into from
Jul 17, 2022

Conversation

awxiaoxian2020
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Jul 17, 2022
@awxiaoxian2020
Copy link
Contributor Author

cc: @yin1999

@yin1999
Copy link
Member

yin1999 commented Jul 17, 2022

I'll review it later today

yin1999
yin1999 reviewed Jul 17, 2022
View reviewed changes
kumascript/macros/HTMLSidebar.ejs Outdated Show resolved Hide resolved
kumascript/macros/HTMLSidebar.ejs Outdated Show resolved Hide resolved
kumascript/macros/LearnSidebar.ejs Outdated Show resolved Hide resolved
kumascript/macros/LearnSidebar.ejs Outdated Show resolved Hide resolved
kumascript/macros/HTMLSidebar.ejs Outdated Show resolved Hide resolved
kumascript/macros/LearnSidebar.ejs Outdated Show resolved Hide resolved
kumascript/macros/HTMLSidebar.ejs Outdated Show resolved Hide resolved
@yin1999
Copy link
Member

yin1999 commented Jul 17, 2022

some suggestions

@awxiaoxian2020 @yin1999
chore(macros/HTML): update zh-CN strings
51bcd8e 
Co-Authored-By: A1lo <yin199909@aliyun.com>
@awxiaoxian2020
Copy link
Contributor Author

some suggestions

We should update the title in some time.

@yin1999
Copy link
Member

yin1999 commented Jul 17, 2022

LGTM. It's time to poke @mdn/mdn-community-engagement

schalkneethling
schalkneethling approved these changes Jul 17, 2022
View reviewed changes
Copy link
Contributor

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @awxiaoxian2020 and @yin1999 🎉

@schalkneethling
Copy link
Contributor

@awxiaoxian2020 for future reference, this repository requires signed commits. You can read more about it here: https://docs.github.com/articles/about-gpg/

@schalkneethling schalkneethling merged commit 7ead275 into mdn:main Jul 17, 2022
@awxiaoxian2020 awxiaoxian2020 deleted the macro branch July 17, 2022 10:33
@awxiaoxian2020
Copy link
Contributor Author

@awxiaoxian2020 for future reference, this repository requires signed commits. You can read more about it here: https://docs.github.com/articles/about-gpg/

Thanks for your reminding! I add the GPG key now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 left review comments

@schalkneethling schalkneethling schalkneethling approved these changes

Assignees
No one assigned
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@awxiaoxian2020 @yin1999 @schalkneethling