refactor translations.js #3090
Merged
refactor translations.js #3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiji-flo
approved these changes
Mar 1, 2021
server/index.js
Outdated
| @@ -47,7 +47,7 @@ async function buildDocumentFromURL(url) { | |||
| // When you're running the dev server and build documents | |||
| // every time a URL is requested, you won't have had the chance to do | |||
| // the phase that happens when you do a regular `yarn build`. | |||
| document.translations = findDocumentTranslations(document); | |||
| document.translations = findDocumentTranslationsByURL(document); | |||
There was a problem hiding this comment.
nit: I think findDocumentTranslationsByURL accepting a document is a little bit misleading maybe we wanna pass just document.url
There was a problem hiding this comment.
You're right. I'm glad you stopped me. Fixed now.
|
Oh I see. You approved but + nit. I'll merge. |
peterbe
added a commit
to peterbe/yari
that referenced
this pull request
Jun 1, 2021
* refactor translations.js * feedback on name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(based on an offline (Slack) conversation)