Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove eslint ignored files #1922

Closed
Rumyra opened this issue Oct 4, 2021 · 2 comments · Fixed by #1959
Closed

Remove eslint ignored files #1922

Rumyra opened this issue Oct 4, 2021 · 2 comments · Fixed by #1959
Labels
Content:JS issues related to JavaScript examples.

Comments

@Rumyra
Copy link
Contributor

Rumyra commented Oct 4, 2021

eslint does not support static initialization blocks in js classes ... yet. This meant two js examples were failing tests - they have both been added to the .eslintignore file. They are:

  • live-examples/js-examples/classes/classes-static-initialization.js
  • live-examples/js-examples/classes/classes-static.js

Once this issue has been resolved and eslint supports static blocks, we can remove these files from the ignore file
@welcome
Copy link

welcome bot commented Oct 4, 2021

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.

@Rumyra Rumyra added the Content:JS issues related to JavaScript examples. label Oct 4, 2021
@ddbeck
Copy link
Contributor

ddbeck commented Oct 4, 2021

The actual changes are:

@wbamberg wbamberg mentioned this issue Nov 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Content:JS issues related to JavaScript examples.
Projects
Yari Platform Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ESLint config for version 8 wbamberg/interactive-examples
2 participants
@ddbeck @Rumyra