Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set compiled function name #466

Merged
merged 2 commits into from Oct 30, 2019
Merged

Conversation

ExE-Boss
Copy link
Collaborator

This sets the name property for the compiled function, so that it matches opts.filename without the file extension.

I also made it so that the default name would be anonymous instead of returnedFn, to match what the Function constructor sets the name to.

@ExE-Boss ExE-Boss requested a review from mde October 20, 2019 16:29
@ExE-Boss ExE-Boss self-assigned this Oct 20, 2019
@ExE-Boss ExE-Boss added the enhancement New feature or request label Oct 20, 2019
@mde mde merged commit 12a7541 into mde:master Oct 30, 2019
@mde
Copy link
Owner

mde commented Oct 30, 2019

LGTM. Thank you for this!

@ExE-Boss ExE-Boss deleted the feat/set-function-name branch October 30, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants