Show compiled templates in debugger #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a sourceURL directive to the generated template function. This makes generated template code visible in the debugger. See https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Debug_eval_sources
|
Very nice, thanks! |
ExE-Boss
approved these changes
Sep 6, 2019
|
The next step would probably be to generate a source map as well. |
This was referenced Nov 22, 2019
Merged
This was referenced Jan 23, 2020
This was referenced Feb 1, 2020
This was referenced Feb 23, 2020
This was referenced Mar 17, 2020
This was referenced Mar 28, 2020
This was referenced Apr 9, 2020
This was referenced May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a sourceURL directive to the generated template function.
This makes generated template code visible in the debugger.
See https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Debug_eval_sources
When loading templates dynamically in the browser (for example using ejs-render-remote) this simple addition is really useful: