Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate concurrency parameter #32

Closed
codekitchen opened this issue Dec 9, 2020 · 2 comments
Closed

validate concurrency parameter #32

codekitchen opened this issue Dec 9, 2020 · 2 comments

Comments

@codekitchen
Copy link

I recently ran into a bug in fast-glob where it was setting concurrency: 0 in some environments. This triggers a nasty situation where all work is just queued up forever and fastq silently never makes progress.

It might be good to validate the concurrency parameter and not allow a value less than 1.

@mcollina
Copy link
Owner

mcollina commented Dec 9, 2020

Good spot! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

@KyleAMathews
Copy link

This should be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants