Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with mutable dataclass fields. #285

Merged
merged 9 commits into from Feb 4, 2022

Conversation

mcmtroffaes
Copy link
Owner

Closes #284.

@jamesjer I'll wait for CI to cycle and perhaps add 3.11 to the github actions; if all is well this should be good to go. Feel free to give this a spin. Thanks again for your help with this!

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #285 (3c9bdd3) into develop (a8b9010) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 3c9bdd3 differs from pull request most recent head a2f71d9. Consider uploading reports for the commit a2f71d9 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           develop      #285    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           47        47            
  Lines         2290      2301    +11     
  Branches       278       403   +125     
==========================================
+ Hits          2290      2301    +11     
Impacted Files Coverage Δ
...sphinxcontrib/bibtex/style/referencing/__init__.py 100.00% <100.00%> (ø)
...inxcontrib/bibtex/style/referencing/author_year.py 100.00% <100.00%> (ø)
...trib/bibtex/style/referencing/basic_author_year.py 100.00% <100.00%> (ø)
...hinxcontrib/bibtex/style/referencing/basic_foot.py 100.00% <100.00%> (ø)
...inxcontrib/bibtex/style/referencing/basic_label.py 100.00% <100.00%> (ø)
...inxcontrib/bibtex/style/referencing/basic_super.py 100.00% <100.00%> (ø)
...nxcontrib/bibtex/style/referencing/extra_author.py 100.00% <100.00%> (ø)
...inxcontrib/bibtex/style/referencing/extra_empty.py 100.00% <100.00%> (ø)
...inxcontrib/bibtex/style/referencing/extra_label.py 100.00% <100.00%> (ø)
...hinxcontrib/bibtex/style/referencing/extra_year.py 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b9010...a2f71d9. Read the comment docs.

@mcmtroffaes mcmtroffaes merged commit aab8ec1 into develop Feb 4, 2022
@mcmtroffaes mcmtroffaes deleted the feature/fix-dataclasses-for-py311 branch February 4, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.11 is pickier about mutable dataclass fields
2 participants