getfilesystemencoding can be None, causing error

[wryun]

In Python before 3.2, it's possible to get None from this. However AWS Codebuild is setting things up, this causes pathlib2 to explode:

...
  File "/codebuild/output/src991325250/src/github.com/.../ve-web/local/lib/python2.7/site-packages/pathlib2/__init__.py", line 928, in _make_child 
    drv, root, parts = self._parse_args(args) 
  File "/codebuild/output/src991325250/src/github.com/.../ve-web/local/lib/python2.7/site-packages/pathlib2/__init__.py", line 885, in _parse_args 
    parts.append(a.encode(sys.getfilesystemencoding())) 
TypeError: encode() argument 1 must be string, not None 

[mcmtroffaes]

Thanks for reporting. I cannot reproduce the problem but I see it's possible according to the documentation: https://docs.python.org/2/library/sys.html#sys.getfilesystemencoding

I've seen other code in the cpython implementation fall back to ascii in these cases (see for instance python/cpython@3741eff), I'll add a patch to do the same in pathlib2.

[mcmtroffaes]

Could you test and confirm that 59e893e fixes the issue that you reported?

[wryun]

Yes, this fixes the issue for me - thanks for the fast response!

[mcmtroffaes]

Splendid. Thanks for confirming!

[mcmtroffaes]

FYI I've just pushed a new release including the fix.