Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pathlib2 switched to new syntax in setup.py without bumping major or minor version #46

Closed
zvezdan opened this issue Sep 19, 2018 · 1 comment

Comments

@zvezdan
Copy link

zvezdan commented Sep 19, 2018

The switch to new syntax for conditional dependencies in pathlib2-2.3.2 causes issues to automated build tooling that uses pex. This line: https://github.com/mcmtroffaes/pathlib2/blob/develop/setup.py#L47 used to be done in extras_require instead of install_requires.

Recent versions of setuptools and wheel are able to parse this new syntax, but older versions enforced by pex are not: https://github.com/pantsbuild/pex/blob/v1.4.5/pex/version.py#L9
Until recently, wheel was also forced to version that is not able to parse new syntax: https://github.com/pantsbuild/pex/blob/v1.4.4/pex/version.py#L11

This would be less of an issue if pathlib2 bumped a version in major or minor instead of just patch part of the version number. This is a breaking change for build systems that worked just fine with pathlib2-2.3.0.

I'm asking if we can do one or both of the following to fix this issue.

  1. Revert to extras_require in version 2.3.x of pathlib, preferably 2.x and perhaps use it only for the next major version?
  2. Perhaps avoid using the new syntax entirely? This is a backport package and those who need a backport package most probably do not have up-to-date environment anyway to parse the new features.
mcmtroffaes added a commit that referenced this issue Nov 29, 2018
@mcmtroffaes
Copy link
Collaborator

Thanks for reporting and sorry for the delay in the response here. I've just pushed a release that uses the old deprecated syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants