Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis 2.6.0 broke this module #16

Closed
LinusU opened this issue Jun 1, 2016 · 3 comments
Closed

Redis 2.6.0 broke this module #16

LinusU opened this issue Jun 1, 2016 · 3 comments

Comments

@LinusU
Copy link

LinusU commented Jun 1, 2016

redis/node-redis@ffaaf0f

This commit broke this module since thenify is using the function name inside an eval statement. Since the name of one function is now restore-asking if fails with a syntax error :(

@LinusU
Copy link
Author

LinusU commented Jun 1, 2016

Also reported here redis/node-redis#1075 and here thenables/thenify#20

@mciparelli
Copy link
Owner

Was this fixed in node_redis already? Is there anything we could do about it to fix this or it's more like a thenify thing?

@LinusU
Copy link
Author

LinusU commented Jun 28, 2016

I don't think that there is anything that needs to be done here since it's fixed upstream, closing...

@LinusU LinusU closed this as completed Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants