Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit #14

Closed
mblayman opened this issue Dec 11, 2021 · 4 comments
Closed

Add pre-commit #14

mblayman opened this issue Dec 11, 2021 · 4 comments

Comments

@mblayman
Copy link
Owner

Use pre-commit to run luacheck and luaformatter
@mblayman
Copy link
Owner Author

The existing pre-commit hooks rely on the system time and don't install the relevant tools. I'll try to get Lua support added to pre-commit so that I can improve this situation for other users (and myself).

Here's the relevant PR: pre-commit/pre-commit#2158

@mblayman
Copy link
Owner Author

Now that Lua support is merged. I need to add hooks for Luacheck and LuaFormatter.

The Luacheck PR is open at lunarmodules/luacheck#48

@mblayman
Copy link
Owner Author

The LuaFormatter PR is at Koihik/LuaFormatter#236

@mblayman
Copy link
Owner Author

Yay, all merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mblayman