{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":304257685,"defaultBranch":"upstream","name":"symfony","ownerLogin":"maxime-aknin","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2020-10-15T08:21:41.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/8659993?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1678357079.0","currentOid":""},"activityList":{"items":[{"before":"92309d7de6b02b2b216d8088e22d9b46218969a1","after":"e11ae31aea070c6ca2c9d3a292708103686f4f72","ref":"refs/heads/patch-1","pushedAt":"2023-10-05T12:54:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fabpot","name":"Fabien Potencier","path":"/fabpot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47313?s=80&v=4"},"commit":{"message":"feature #51804 [Security] Make `impersonation_path()` argument mandatory and add `impersonation_url()` (alexandre-daubois)\n\nThis PR was merged into the 6.4 branch.\n\nDiscussion\n----------\n\n[Security] Make `impersonation_path()` argument mandatory and add `impersonation_url()`\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 6.4\n| Bug fix?      | yes\n| New feature?  | yes\n| Deprecations? | no\n| Tickets       | -\n| License       | MIT\n\nFollow-up of https://github.com/symfony/symfony/pull/50030\n\nWhen documenting this function, I found out that the`identifier` argument was optional, which seemed weird to me given the function purpose.\n\nI then had a look at the implementation, and I saw that `ImpersonateUrlGenerator::generateImpersonationPath()` accepts a nullable string. However, the underlying call to `ImpersonateUrlGenerator::buildPath()` doesn't accept a nullable string. I propose to make the `identifier` argument mandatory, which makes more sense here.\n\nI also added the missing Changelog line and `impersonation_url()`\n\nCommits\n-------\n\n5d71d95865 [Security] Make `impersonation_path()` argument mandatory and add `impersonation_url()`","shortMessageHtmlLink":"feature <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1921509735\" data-permission-text=\"Title is private\" data-url=\"https://github.com/symfony/symfony/issues/51804\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/symfony/symfony/pull/51804/hovercard\" href=\"https://github.com/symfony/symfony/pull/51804\">symfony#51804</a> [Security] Make <code>impersonation_path()</code> argument…"}},{"before":"8b420d45bc2f7909b0fcffbcab704db5b4117afc","after":"92309d7de6b02b2b216d8088e22d9b46218969a1","ref":"refs/heads/patch-1","pushedAt":"2023-10-05T12:23:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"},"commit":{"message":"Fix potential XSS in WebhookController.php","shortMessageHtmlLink":"Fix potential XSS in WebhookController.php"}},{"before":null,"after":"2e4f39e8dad20363580c0f83c7e46a9ffa27e657","ref":"refs/heads/doctrine-messenger-setup-dbal-schema","pushedAt":"2023-03-09T10:17:59.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"},"commit":{"message":"feat: add schema option to dbal connection auto setup","shortMessageHtmlLink":"feat: add schema option to dbal connection auto setup"}},{"before":"6bbab591c80af23d98c265428dc5b5f1c3c72f59","after":null,"ref":"refs/heads/5.1","pushedAt":"2023-03-09T09:57:07.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"30bf38ac160bd8d6f71c79c99a9ac33e923d056b","after":null,"ref":"refs/heads/yceruto-codeowner","pushedAt":"2023-03-09T09:57:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"f5a4a5d715e0e718d2570b14b2586474c749029e","after":null,"ref":"refs/heads/4.4","pushedAt":"2023-03-09T09:57:03.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"89dddd17708cf7e1bb8ca56f95c77c529f811e6e","after":null,"ref":"refs/heads/3.4","pushedAt":"2023-03-09T09:57:01.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"2c14c5fca7182f11abf0a692e471326f14119c29","after":null,"ref":"refs/heads/5.0","pushedAt":"2023-03-09T09:57:00.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"43688482bc01c40ec421ff9552e1455df460d3f3","after":null,"ref":"refs/heads/4.3","pushedAt":"2023-03-09T09:56:59.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"7b0ca3ab5678232f876a95991b66778f4aaa33e3","after":null,"ref":"refs/heads/4.2","pushedAt":"2023-03-09T09:56:57.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"88f3ef62d6ab870128352c8686c7889562698faf","after":null,"ref":"refs/heads/2.8","pushedAt":"2023-03-09T09:56:55.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"0578fdf038f225524929373bf1b0d33129f1be13","after":null,"ref":"refs/heads/4.1","pushedAt":"2023-03-09T09:56:54.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"4d0899c5e3b30b3be591f8349ce92529d79bee93","after":null,"ref":"refs/heads/2.7","pushedAt":"2023-03-09T09:56:53.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"a1cce5a8b410d3a760bd86bf9250236858a7905d","after":null,"ref":"refs/heads/4.0","pushedAt":"2023-03-09T09:56:50.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"e8d2a2ed1f1ad9726388b97a0e76b20405379d1b","after":null,"ref":"refs/heads/3.3","pushedAt":"2023-03-09T09:56:49.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"fc9f9470e81e6fb59bd826d8040b961f7ed30f94","after":null,"ref":"refs/heads/3.2","pushedAt":"2023-03-09T09:56:48.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"96e7dede3ddc9e3b3392f5cc93e26eca77545a89","after":null,"ref":"refs/heads/3.1","pushedAt":"2023-03-09T09:56:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"5478a9d20d181e8d5a0ef532906e67b6d4d7bd79","after":null,"ref":"refs/heads/3.0","pushedAt":"2023-03-09T09:56:45.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"0baa58d4e4bb006c4ae68f75833b586bd3cb6e6f","after":null,"ref":"refs/heads/2.3","pushedAt":"2023-03-09T09:56:44.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"240e9648af3daa5ed19580fdec74d768e30692a6","after":null,"ref":"refs/heads/2.6","pushedAt":"2023-03-09T09:56:42.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"5c83d12f2fbe93622e6ae2aad72f4033adbebe36","after":null,"ref":"refs/heads/2.5","pushedAt":"2023-03-09T09:56:37.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"daed178afd4700dd18f4fb0ea6b72dcfd9a4792a","after":null,"ref":"refs/heads/2.4","pushedAt":"2023-03-09T09:56:36.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"c07227e5b3c28a429cd2fa2be705284059b613db","after":null,"ref":"refs/heads/2.2","pushedAt":"2023-03-09T09:56:35.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"fc0a09a2052e9275c16b5ab7af426935fe432f39","after":null,"ref":"refs/heads/2.1","pushedAt":"2023-03-09T09:56:34.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"3968f00539be5e14bfcb681a3bb2429a7cacb349","after":null,"ref":"refs/heads/2.0","pushedAt":"2023-03-09T09:56:32.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"394a69485602203467a6e94e66f536e48ab4127f","after":null,"ref":"refs/heads/patch-1","pushedAt":"2023-03-09T09:56:23.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":"898a72321659bf54dd48e6bab373137a62f9a7d2","after":null,"ref":"refs/heads/main","pushedAt":"2023-03-09T09:55:01.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":null,"after":"898a72321659bf54dd48e6bab373137a62f9a7d2","ref":"refs/heads/upstream","pushedAt":"2023-03-09T09:55:00.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"},"commit":{"message":"minor #49640 [SecurityBundle] Minor code cleanup in SecurityExtension (maxbeckers)\n\nThis PR was merged into the 6.3 branch.\n\nDiscussion\n----------\n\n[SecurityBundle] Minor code cleanup in SecurityExtension\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 6.3\n| Bug fix?      | no\n| New feature?  | no\n| Deprecations? | no\n| Tickets       | n/a\n| License       | MIT\n| Doc PR        | n/a\n\nRemove a var only used once.\n\nCommits\n-------\n\nedf8d1dd4b [Seurity] Minor code cleanup in SecurityExtension","shortMessageHtmlLink":"minor <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1615499534\" data-permission-text=\"Title is private\" data-url=\"https://github.com/symfony/symfony/issues/49640\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/symfony/symfony/pull/49640/hovercard\" href=\"https://github.com/symfony/symfony/pull/49640\">symfony#49640</a> [SecurityBundle] Minor code cleanup in SecurityEx…"}},{"before":"898a72321659bf54dd48e6bab373137a62f9a7d2","after":null,"ref":"refs/heads/dev-maxime-aknin","pushedAt":"2023-03-09T09:54:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"}},{"before":null,"after":"898a72321659bf54dd48e6bab373137a62f9a7d2","ref":"refs/heads/main","pushedAt":"2023-03-09T09:54:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"maxime-aknin","name":"Maxime Aknin","path":"/maxime-aknin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8659993?s=80&v=4"},"commit":{"message":"minor #49640 [SecurityBundle] Minor code cleanup in SecurityExtension (maxbeckers)\n\nThis PR was merged into the 6.3 branch.\n\nDiscussion\n----------\n\n[SecurityBundle] Minor code cleanup in SecurityExtension\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 6.3\n| Bug fix?      | no\n| New feature?  | no\n| Deprecations? | no\n| Tickets       | n/a\n| License       | MIT\n| Doc PR        | n/a\n\nRemove a var only used once.\n\nCommits\n-------\n\nedf8d1dd4b [Seurity] Minor code cleanup in SecurityExtension","shortMessageHtmlLink":"minor <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1615499534\" data-permission-text=\"Title is private\" data-url=\"https://github.com/symfony/symfony/issues/49640\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/symfony/symfony/pull/49640/hovercard\" href=\"https://github.com/symfony/symfony/pull/49640\">symfony#49640</a> [SecurityBundle] Minor code cleanup in SecurityEx…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADkCnUEQA","startCursor":null,"endCursor":null}},"title":"Activity · maxime-aknin/symfony"}