Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove LOGIN_DISABLED config #697

Open
davidism opened this issue Jul 25, 2022 · 0 comments
Open

remove LOGIN_DISABLED config #697

davidism opened this issue Jul 25, 2022 · 0 comments

Comments

@davidism
Copy link
Collaborator

It should not be possible to disable login. Especially not as a config, it doesn't make sense to configure this per-deployment. I'm not sure how it would even be used in testing, since any function protected by login would presumably also be using current_user and break when that isn't set. We also have LoginTestClient to make a given user logged in for test requests.
@davidism davidism self-assigned this Nov 2, 2023
@davidism davidism removed their assignment Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidism