Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dead link #446

Merged
merged 1 commit into from Aug 9, 2019
Merged

Updated dead link #446

merged 1 commit into from Aug 9, 2019

Conversation

makew0rld
Copy link
Contributor

No description provided.

@maxcountryman
Copy link
Owner

Thanks!

@maxcountryman maxcountryman merged commit 30735a3 into maxcountryman:master Aug 9, 2019
@davidism
Copy link
Collaborator

davidism commented Aug 9, 2019

@maxcountryman pr #444 discussed this too

That particular snippet is ok, I think. But the quality, up-to-date-ness, and long term helpfulness of the snippet repository overall was not good, and there had been a giant warning on it for years.

I'd much rather see that snippet brought into Flask-Login, either in code or in docs, rather than keeping that site alive by linking to the archive.

@maxcountryman
Copy link
Owner

@davidism hm maybe we should remove it instead.

@davidism
Copy link
Collaborator

davidism commented Aug 9, 2019

I think adding the snippet to the docs is fine. It might even be useful to add as a function so we can test and improve it.

@makew0rld
Copy link
Contributor Author

I agree, I was just making a quick fix. Adding it to the docs or even better, the lib itself, would be great to see.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants