New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom test client #431
Custom test client #431
Conversation
This makes sense to me! 👍 |
9bb2449
to
7780656
Compare
Great! Do you have any feedback on the functionality or the documentation? I know that Flask-Login sets more values in the session cookie than And are the docs clear? I always want to verify that my documentation is understandable to someone who didn't write the code. 😄 |
using the Flask-Login extension. | ||
""" | ||
|
||
def __init__(self, *args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way is more explicit:
def __init__(self, user=None, fresh_login=True, *args, **kwargs):
I know the FlaskClient
docs show using kwargs.pop
so either is fine.
Great, thanks for merging! Any idea when there will be a new release of Flask-Login, so people can use this feature? |
@maxcountryman does the releases. Thanks for adding this, it will be very helpful when testing. |
Cool. Let's move this discussion over to issue #425. |
Having a custom test client makes it easier to write automated tests using Flask-Login.