Set session ID when setting next #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, looks good but why not use your newer test that's easier to read? #401 (comment) |
|
Unfortunately this fails the newer test (I think). This fixes the problem by ensuring that _id is set when next is set, which keeps the session intact. |
|
Basically, there are two ways to fix the bug:
This solves it with option 1, and the test will succeed with either solution. The shorter test is a unit test for option 2. |
alanhamlett
approved these changes
Jul 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #401.
It may make sense to refactor the "login session" code so that this doesn't need to be a repeated issue throughout the code.