Simplify user loading #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfriend
reviewed
Jun 4, 2021
| user = self._request_callback(request) | ||
| if user is not None: | ||
| app = current_app._get_current_object() | ||
| user_loaded_from_request.send(app, user=user) |
There was a problem hiding this comment.
This change makes it impossible to use current_user until _load_user has returned. This is a problem because if you want to use a signal like user_loaded_from_request, accessing current_user causes immediate RecursionError
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a few things to simplify user loading:
LoginManager._load_userLoginManager.reload_usertoLoginManager._update_request_context_with_userLoginManager._update_request_context_with_userLoginManager._load_useruser_loaderandrequest_loaderundefined