Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSL colors from Ckeditor not supported in some e-mailclients #13718

Open
1 task done
dev-marcel opened this issue May 2, 2024 · 1 comment
Open
1 task done

HSL colors from Ckeditor not supported in some e-mailclients #13718

dev-marcel opened this issue May 2, 2024 · 1 comment
Labels
bug Issues or PR's relating to bugs builder-grapesjs Anything related to the GrapesJS email or landing page builders editor Anything related to CKEditor email Anything related to email

Comments

@dev-marcel
Copy link
Contributor

dev-marcel commented May 2, 2024

Mautic Version

5.0.x series

Way of installing

I downloaded a release from https://www.mautic.org/mautic-releases

PHP version

8.1

What browsers are you seeing the problem on?

Not relevant

What happened?

The Ckeditor used in the template editor uses HSL colors in tekst, this is not supported by quit some mailclients, for Example all Outlook clients: https://www.campaignmonitor.com/css/color-background/hsl-colors/

How can we reproduce this issue?

Step 1: Make a MJML e-mail (for example with the truly personal theme)
Step 2: Edit the e-mail, dubble click on some text
Step 3: Change the color of the text
Step 4: Send test mail and check it in Outlook

We should set a configuration in the colorpicker: https://ckeditor.com/docs/ckeditor5/latest/api/module_ui_colorpicker_utils-ColorPickerOutputFormat.html, prefered rgb since its fully supported for all mail clients (https://www.campaignmonitor.com/css/color-background/rgb-colors/)

Relevant log output

No response

Code of Conduct

  • I confirm that I have read and agree to follow this project's Code of Conduct




Care about this issue? Want to get it resolved sooner? If you are a member of Mautic, you can add some funds to the Bounties Project so that the person who completes this task can claim those funds once it is merged by a member of the core team! Read the docs here.

@dev-marcel dev-marcel added bug Issues or PR's relating to bugs needs-triage For new issues/PRs that need to be triaged labels May 2, 2024
@RCheesley RCheesley added email Anything related to email editor Anything related to CKEditor builder-grapesjs Anything related to the GrapesJS email or landing page builders and removed needs-triage For new issues/PRs that need to be triaged labels May 2, 2024 — with Slack
@dev-marcel
Copy link
Contributor Author

dev-marcel commented May 24, 2024

So i figured out it a it is an option for Ckeditor:
.fontColor = { colorPicker: { format: 'hex' } };

for now as quickfix i added it to getCkeConf in the builder.js of GrapeJs.

This fixes the color picker giving Hex colors, but not the default colors the editor shows. This can also be overidden by
fontColor: {
colors: [{
color: '#E64C4C',
label: 'Red'
},
{
color: '#E6994C',
label: 'Orange'
},
{
color: '#E6E64C',
label: 'Yellow'
},
]
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs builder-grapesjs Anything related to the GrapesJS email or landing page builders editor Anything related to CKEditor email Anything related to email
Projects
None yet
Development

No branches or pull requests

2 participants