Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to update .pdl files #164

Open
AlexStorm1313 opened this issue Jul 22, 2023 · 0 comments
Open

How to update .pdl files #164

AlexStorm1313 opened this issue Jul 22, 2023 · 0 comments

Comments

@AlexStorm1313
Copy link
Contributor

AlexStorm1313 commented Jul 22, 2023

I'm wondering how I can elegantly update the .pdl files used for rust code generation. What I have seen looking through the code is that there is a revision variable that can be set, but does this automatically mean the .pdl files for that revision are downloaded from e.x. https://github.com/ChromeDevTools/devtools-protocol or is this variable set manually to match the included .pdl files in the project? My use case in this instance is that I want to use the unstable 1.3 protocol.

I may be getting ahead of myself but, would it be nice to set the protocol version with a feature flag just like the runtime is specified?

Edit: It seems like running the test(generate.rs) with a new revision specified updates the pdl files and subsequently updates the generated rust code. Can someone give some more explanation on this topic. It seems like the docs on this topic are outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant