Add err handling in Glob func #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi, thanks for developing that lib, it's really helpful!
But recently I spot one problem and IMO is worth to fix it :)
Currently, the error returned from FastWalk is ignored. This may lead to strange behavior. The path traversing is done in a non-deterministic way if the is more workes, you can end up with a behavior that sometimes the pattern is found and sometimes not as it depends on when it will exit the loop with an error. You as a lib user, you do not know what is the issue because the underlying error is not returned.
This pull request fixes this issue and adds a test to coverage for that scenario. Unfortunately, I was not able to add it to the common
testGlobscases as adding a fixture with wrong permission affects other test cases.