Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build tag to enable OSTRACE() logging #1067

Merged
merged 1 commit into from Aug 16, 2022
Merged

Conversation

benbjohnson
Copy link
Contributor

This pull request adds the sqlite_os_trace build tag which sets the following compilation flags:

  • SQLITE_FORCE_OS_TRACE=1
  • SQLITE_DEBUG_OS_TRACE=1

This produces verbose debugging output of every operating system call made by SQLite. These two flags are the same as the flags set in Makefile.msc in the SQLite repository:

https://github.com/sqlite/sqlite/blob/cf2ad7ae3652a3fc47d3625a9bf44e5239b4d35f/Makefile.msc#L837-L840

This commit adds the `sqlite_os_trace` build tag which sets the
`SQLITE_FORCE_OS_TRACE` and `SQLITE_DEBUG_OS_TRACE` compilation
flags. This produces verbose debugging output of every operating
system call made by SQLite.
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2022

Codecov Report

Merging #1067 (eed275a) into master (3ccccfb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1067   +/-   ##
=======================================
  Coverage   46.29%   46.29%           
=======================================
  Files          11       11           
  Lines        1499     1499           
=======================================
  Hits          694      694           
  Misses        666      666           
  Partials      139      139           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ccccfb...eed275a. Read the comment docs.

@mattn mattn merged commit a2e94c9 into mattn:master Aug 16, 2022
@mattn
Copy link
Owner

mattn commented Aug 16, 2022

Thank you

@benbjohnson benbjohnson deleted the os_trace branch August 16, 2022 15:25
@benbjohnson
Copy link
Contributor Author

Thanks, @mattn!

patrickdevivo added a commit to mergestat/mergestat that referenced this pull request Oct 26, 2022
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/mattn/go-sqlite3](https://togithub.com/mattn/go-sqlite3) |
require | patch | `v1.14.15` -> `v1.14.16` |

---

### Release Notes

<details>
<summary>mattn/go-sqlite3</summary>

###
[`v1.14.16`](https://togithub.com/mattn/go-sqlite3/releases/tag/v1.14.16)

[Compare
Source](https://togithub.com/mattn/go-sqlite3/compare/v1.14.15...v1.14.16)

#### What's Changed

- Add build tag to enable OSTRACE() logging by
[@&#8203;benbjohnson](https://togithub.com/benbjohnson) in
[mattn/go-sqlite3#1067
- TestQueryer: actually check Rows returned by
[@&#8203;ohwgiles](https://togithub.com/ohwgiles) in
[mattn/go-sqlite3#1062
- Update README to fix reference URL by
[@&#8203;shibukawa](https://togithub.com/shibukawa) in
[mattn/go-sqlite3#1082
- Fix test queryer test by
[@&#8203;joshbuddy](https://togithub.com/joshbuddy) in
[mattn/go-sqlite3#1079
- Rollback on constraint failure by
[@&#8203;joshbuddy](https://togithub.com/joshbuddy) in
[mattn/go-sqlite3#1071
- Fix "ennviroment" by
[@&#8203;RewardedIvan](https://togithub.com/RewardedIvan) in
[mattn/go-sqlite3#1077
- こんにちわ is wrong Japanse, Correct word is こんにちは by
[@&#8203;KiYugadgeter](https://togithub.com/KiYugadgeter) in
[mattn/go-sqlite3#1085
- Add test for sqlite_math_functions tag by
[@&#8203;lggruspe](https://togithub.com/lggruspe) in
[mattn/go-sqlite3#1059
- remove unuseful ldflags for windows platform. by
[@&#8203;kkqy](https://togithub.com/kkqy) in
[mattn/go-sqlite3#1084
- Cross Compiling for Mac OS via `musl-cross` by
[@&#8203;jodosha](https://togithub.com/jodosha) in
[mattn/go-sqlite3#1090
- Update README.md to include vtable feature by
[@&#8203;dvas0004](https://togithub.com/dvas0004) in
[mattn/go-sqlite3#1100
- Updating vtable example, "BestIndex" method by
[@&#8203;dvas0004](https://togithub.com/dvas0004) in
[mattn/go-sqlite3#1099
- Update amalgamation code by
[@&#8203;mattn](https://togithub.com/mattn) in
[mattn/go-sqlite3#1104

#### New Contributors

- [@&#8203;ohwgiles](https://togithub.com/ohwgiles) made their first
contribution in
[mattn/go-sqlite3#1062
- [@&#8203;shibukawa](https://togithub.com/shibukawa) made their first
contribution in
[mattn/go-sqlite3#1082
- [@&#8203;joshbuddy](https://togithub.com/joshbuddy) made their first
contribution in
[mattn/go-sqlite3#1079
- [@&#8203;RewardedIvan](https://togithub.com/RewardedIvan) made their
first contribution in
[mattn/go-sqlite3#1077
- [@&#8203;KiYugadgeter](https://togithub.com/KiYugadgeter) made their
first contribution in
[mattn/go-sqlite3#1085
- [@&#8203;lggruspe](https://togithub.com/lggruspe) made their first
contribution in
[mattn/go-sqlite3#1059
- [@&#8203;kkqy](https://togithub.com/kkqy) made their first
contribution in
[mattn/go-sqlite3#1084
- [@&#8203;jodosha](https://togithub.com/jodosha) made their first
contribution in
[mattn/go-sqlite3#1090
- [@&#8203;dvas0004](https://togithub.com/dvas0004) made their first
contribution in
[mattn/go-sqlite3#1100

**Full Changelog**:
mattn/go-sqlite3@v1.14.15...v1.14.16

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/mergestat/mergestat).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xLjUiLCJ1cGRhdGVkSW5WZXIiOiIzNC4xLjUifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants