Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for defining an "eponymous only" virtual table #885

Merged
merged 3 commits into from Dec 26, 2020
Merged

add support for defining an "eponymous only" virtual table #885

merged 3 commits into from Dec 26, 2020

Conversation

patrickdevivo
Copy link
Contributor

@patrickdevivo patrickdevivo commented Dec 2, 2020 •
edited

As suggested here: #846 (comment)

Ultimately, should close #846

  • Add some test cases (at least one)
  • Add an example demonstrating usage

@patrickdevivo patrickdevivo marked this pull request as ready for review December 2, 2020 22:34
@patrickdevivo
Copy link
Contributor Author

Just wanted to notify @rittneje @mattn, this is a follow-up to #846 that adds support for eponymous only virtual table modules (thank you @rittneje for the instructions/guidance!). Hopefully this is a reasonable addition/change, please let me know - happy to make any amendments!

@patrickdevivo patrickdevivo mentioned this pull request Dec 4, 2020
Closed
@anacrolix
Copy link

Looks great!

@mattn
Copy link
Owner

mattn commented Dec 26, 2020

Looks great. Thanks.

@mattn mattn merged commit 92d2371 into mattn:master Dec 26, 2020
@patrickdevivo patrickdevivo deleted the eponymous-only-vtab branch August 11, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eponymous-only virtual tables
3 participants
@patrickdevivo @anacrolix @mattn