Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite3_test.go: Move Go 1.13 test to sqlite3_go113_test.go #883

Merged
merged 1 commit into from Nov 16, 2020

Conversation

evanj
Copy link
Contributor

@evanj evanj commented Nov 16, 2020

Commit 4f7abea added a test that uses Conn.Raw, which was added in
Go >= 1.13. The go-sqlite3 project runs tests with Go >= 1.11. Remove
the test from sqlite3_test.go, so it only runs with the correct
versions of Go.

Instead of adding a new test, modify the existing test that already
uses Conn.Raw() to check the type of driverConn.

Fixes issue from #882

Commit 4f7abea added a test that uses Conn.Raw, which was added in
Go >= 1.13. The go-sqlite3 project runs tests with Go >= 1.11. Remove
the test from sqlite3_test.go, so it only runs with the correct
versions of Go.

Instead of adding a new test, modify the existing test that already
uses Conn.Raw() to check the type of driverConn.
@mattn
Copy link
Owner

mattn commented Nov 16, 2020

Thank you! I'll merge after CI pass.

@evanj
Copy link
Contributor Author

evanj commented Nov 16, 2020

The Windows failure is: --- FAIL: TestExecContextCancel (57.89s) sqlite3_go18_test.go:170: 1000000 <nil> 26.4808527s sqlite3_go18_test.go:173: <nil> context deadline exceeded which might be helped by #879 . The Mac failure is the one that is always happening on Mac OS X with 1.11 due to some dependency issue that I haven't looked at.

I hope I did this correctly this time! 😄 thank you!

@mattn mattn merged commit 70c7709 into mattn:master Nov 16, 2020
@mattn
Copy link
Owner

mattn commented Nov 16, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants