sqlite3.go: remove -DSQLITE_DISABLE_INTRINSIC: better builds #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This "disables the use of compiler-specific built-in functions such as __builtin_bswap32()" (from the SQLite docs) so this change might produce slightly better code. My primary motivation, however, is that the "default" configuration for SQLite, which is widely tested, does not set this preprocessor macro. From looking at Github issues, it appears this was added to avoid a build error on Mac OS X 10.11, in 2017: mattn#386 There have been a number of changes to sqlite3 since we tried this last. I think it would be worth trying to remove this setting again. I found a machine running Mac OS X 10.11.6. It was able to build and run the tests in this package with this change. Mac OS X 10.11 is has not been supported by Apple since 2018 (currently Apple is releasing updates for Mac OS 10.13 and newer; 11 is the current release). However, Go 1.14 is supported, and it requires Mac OS X 10.11 or newer: https://golang.org/doc/go1.14 Go 1.15 only supports Mac OS 10.12 and newer: https://golang.org/doc/go1.15
|
Good to hear.
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "disables the use of compiler-specific built-in functions such
as __builtin_bswap32()" (from the SQLite docs) so this change might
produce slightly better code. My primary motivation, however, is that
the "default" configuration for SQLite, which is widely tested, does
not set this preprocessor macro.
From looking at Github issues, it appears this was added to avoid a
build error on Mac OS X 10.11, in 2017:
#386
There have been a number of changes to sqlite3 since then.
I found a machine running Mac OS X 10.11.6. It was able to build and
run the tests in this package with this change.
Mac OS X 10.11 is has not been supported by Apple since 2018
(currently Apple is releasing updates for Mac OS 10.13 and newer; 11
is the current release). However, Go 1.14 is supported, and it
requires Mac OS X 10.11 or newer: https://golang.org/doc/go1.14
Go 1.15 only supports Mac OS 10.12 and newer:
https://golang.org/doc/go1.15