Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quote include instead of angled include for sqlite3-binding.h #868

Merged
merged 1 commit into from Oct 25, 2021

Conversation

yihanzhen
Copy link
Contributor

I'm trying to depend on this library using bazel. After upgrading to macOS Catalina I keep seeing the error:

/private/var/tmp/_bazel_i/292155d2803b74186baeb737a4c74ee8/sandbox/darwin-sandbox/550/execroot/project/external/com_github_mattn_go_sqlite3/backup.go:10:10: error: 'sqlite3-binding.h' file not found with <angled> include; use "quotes" instead
#include <sqlite3-binding.h>
         ^~~~~~~~~~~~~~~~~~~
         "sqlite3-binding.h

Hopefully this PR would fix the issue for using this library with bazel while not affecting any other use cases.

@codecov-io
Copy link

codecov-io commented Oct 25, 2020

Codecov Report

Merging #868 (0d404bd) into master (3cbdae7) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
- Coverage   46.80%   46.67%   -0.14%     
==========================================
  Files          11       11              
  Lines        1457     1457              
==========================================
- Hits          682      680       -2     
- Misses        640      641       +1     
- Partials      135      136       +1     
Impacted Files Coverage Δ
backup.go 83.33% <ø> (ø)
callback.go 58.16% <ø> (ø)
error.go 81.81% <ø> (ø)
sqlite3.go 52.84% <ø> (-0.23%) ⬇️
sqlite3_context.go 0.00% <ø> (ø)
sqlite3_load_extension.go 59.37% <ø> (ø)
sqlite3_type.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cbdae7...0d404bd. Read the comment docs.

@yihanzhen
Copy link
Contributor Author

The CI on macOS failed at setting up dependencies before running Go tests. And chance to rerun them?

@mattn
Copy link
Owner

mattn commented Dec 26, 2020

Could you please rebase from master branch?

@yihanzhen
Copy link
Contributor Author

Done!

@mattn mattn merged commit 2b131e0 into mattn:master Oct 25, 2021
@mattn
Copy link
Owner

mattn commented Oct 25, 2021

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants