Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RowsColumnTypeNullable not implemented #848

Merged
merged 1 commit into from Dec 26, 2020
Merged

RowsColumnTypeNullable not implemented #848

merged 1 commit into from Dec 26, 2020

Conversation

jinzhu
Copy link
Contributor

@jinzhu jinzhu commented Sep 1, 2020

Hello @mattn

When I am trying the columnType's Nullable method, seems it always returns true although it is not implemented yet, maybe we should comment out this method right now or always return false, false?

Thank you.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020

Codecov Report

Merging #848 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
+ Coverage   47.26%   47.31%   +0.04%     
==========================================
  Files          12       12              
  Lines        1917     1915       -2     
==========================================
  Hits          906      906              
+ Misses        876      874       -2     
  Partials      135      135              
Impacted Files Coverage Δ
sqlite3_type.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 862b959...c010ea3. Read the comment docs.

@jinzhu
Copy link
Contributor Author

jinzhu commented Sep 9, 2020

Seems the CI error not related to the PR change

@mattn mattn merged commit 66ff625 into mattn:master Dec 26, 2020
@mattn
Copy link
Owner

mattn commented Dec 26, 2020

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants