Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go-pointer instead of uintptr hacks. #814

Merged
merged 7 commits into from Aug 26, 2020
Merged

Use go-pointer instead of uintptr hacks. #814

merged 7 commits into from Aug 26, 2020

Conversation

mattn
Copy link
Owner

@mattn mattn commented May 15, 2020

Fixes #791

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2020

Codecov Report

Merging #814 into master will increase coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
+ Coverage   46.44%   46.48%   +0.04%     
==========================================
  Files          12       12              
  Lines        1912     1908       -4     
==========================================
- Hits          888      887       -1     
+ Misses        888      885       -3     
  Partials      136      136              
Impacted Files Coverage Δ
sqlite3.go 50.94% <70.00%> (ø)
callback.go 58.96% <85.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d4145...6e50455. Read the comment docs.

@mattn mattn merged commit 6a8b301 into master Aug 26, 2020
@mattn mattn deleted the fix-vet branch August 26, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go vet: possible misuse of unsafe.Pointer
2 participants