Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #808: remove goconvey #809

Merged
merged 2 commits into from May 14, 2020
Merged

Fix #808: remove goconvey #809

merged 2 commits into from May 14, 2020

Conversation

itizir
Copy link
Contributor

@itizir itizir commented May 3, 2020

Closes #808.
Closes #810.

@coveralls
Copy link

coveralls commented May 3, 2020

Coverage Status

Coverage decreased (-0.2%) to 53.063% when pulling f910743 on itizir:patch-1 into 61ad8da on mattn:master.

@itizir
Copy link
Contributor Author

itizir commented May 4, 2020

Hmmm. Not clear to me whether the coveralls change did anything. Did I misunderstand something?

@itizir
Copy link
Contributor Author

itizir commented May 4, 2020

Oooh! I get it now: since the latest master commit only ran 4 out of 12 jobs (because of failures due to #808), coveralls computed coverage based on those 4 only, and they happen to have slightly higher coverage... 🤦

@mattn mattn merged commit 44b2a63 into mattn:master May 14, 2020
@mattn
Copy link
Owner

mattn commented May 14, 2020

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent test coverage reports smartystreets/goconvey now requiring go 1.13
3 participants