Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 'regex' early termination of returned rows #805

Merged
merged 1 commit into from May 2, 2020

Conversation

ShanePerron
Copy link
Contributor

Once the regex encountered the first instance of a non-match, it would return without processing the rest of the rows in the statement. This change allows it to process the remaining, only setting the sqlite3_result_int to zero then continuing. This worked fine for the example as it only had one item to process.

Once the regex encountered the first instance of a non-match, it would return without processing the rest of the rows in the statement. This change allows it to process the remaining, only setting the sqlite3_result_int to zero then continuing. This worked fine for the example as it only had one item to process.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 53.063% when pulling 853068c on ShanePerron:patch-1 into 98a44bc on mattn:master.

@mattn mattn merged commit 61ad8da into mattn:master May 2, 2020
@mattn
Copy link
Owner

mattn commented May 2, 2020

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants