Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop static_mock.go #1218

Open
mattn opened this issue Feb 8, 2024 · 0 comments
Open

Drop static_mock.go #1218

mattn opened this issue Feb 8, 2024 · 0 comments

Comments

@mattn
Copy link
Owner

mattn commented Feb 8, 2024

The current implementation of static_mock.go is not sufficient because it does not expose all the constants/variables and functions exposed by the cgo enabled sqlite3 package as dummies. However, adding dummy constants/variables and functions to this would require maintenance effort to ensure that go-sqlite3 can be built with !cgo in the future.

My opinion is the drop of statck_mock.go. Anyone's opinion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant