Fix issue 48: single-quote+ParseEnv bug #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baseline, single-quote and double quote tests. w/o fix single-quote test breaks, other 2 work.
Fixes issues with parsing shell lines with single quotes used to group things (eg. subshell calls). Fix was to set `got` state to `argQuoted` as the double quote path used (and which worked for it).
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
=======================================
Coverage 89.62% 89.62%
=======================================
Files 3 3
Lines 212 212
=======================================
Hits 190 190
Misses 15 15
Partials 7 7
Continue to review full report at Codecov.
|
|
Thank you. I'll check this in later. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with parsing shell lines with single quotes used to group things (eg. subshell calls).
Fix was to set
gotstate toargQuotedas the double quote path used (and which worked for it).Fixes #48