Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix underscore names in tests #62

Merged
merged 1 commit into from Mar 23, 2022
Merged

Conversation

itchyny
Copy link
Collaborator

@itchyny itchyny commented Mar 23, 2022

Like it or not, Go linters do NOT like underscores in Go names. The test file already contains lcctype in other places so I renamed it as suggested by linters.

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

Merging #62 (011b00b) into master (4190c90) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files           3        3           
  Lines         171      171           
=======================================
  Hits          160      160           
  Misses          6        6           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4190c90...011b00b. Read the comment docs.

@mattn
Copy link
Owner

mattn commented Mar 23, 2022

I am not that concerned about it. Thanks! 👍

@mattn mattn merged commit f9d5553 into mattn:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants