synchronize access to Console (fixes #48) #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattn willing to take a quick look? Seems to be a valid PR 👍 |
mattn
reviewed
Jun 24, 2020
colorable_windows.go
Outdated
| @@ -430,8 +431,14 @@ func atoiWithDefault(s string, def int) (int, error) { | |||
| return strconv.Atoi(s) | |||
| } | |||
|
|
|||
| var ( | |||
| writeMutex sync.Mutex | |||
There was a problem hiding this comment.
This mutex have to be a field of Writer.
segrey
force-pushed
the
sync-access-to-console
branch
from
e8149f0
to
94e912b
Compare
segrey
force-pushed
the
sync-access-to-console
branch
from
94e912b
to
b6d341e
Compare
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
=======================================
Coverage 90.00% 90.00%
=======================================
Files 2 2
Lines 40 40
=======================================
Hits 36 36
Misses 4 4 Continue to review full report at Codecov.
|
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.