Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modals don't show when using Routify and/or Capacitor #4

Closed
Zettexe opened this issue Aug 2, 2021 · 3 comments
Closed

Modals don't show when using Routify and/or Capacitor #4

Zettexe opened this issue Aug 2, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@Zettexe
Copy link

Zettexe commented Aug 2, 2021

Describe the bug
I tried using svelte-capacitor template and adding svelte-modals but the modals don't seem to work at all and without error messages

Reproduction

  1. git clone https://github.com/drannex42/svelte-capacitor
  2. npm install
  3. npm install svelte-modals
  4. Add basic examples from svelte-modals readme
  5. npm run dev:start
@Zettexe Zettexe added the bug Something isn't working label Aug 2, 2021
@mattjennings
Copy link
Owner

I just ran into this yesterday. There's a Vite bug that causes this but the work around is to add this to your vite.config.js:

  optimizeDeps: {
    exclude: ['svelte-modals'],
  }

@Zettexe
Copy link
Author

Zettexe commented Aug 2, 2021

Yep, seems to work just fine with that included

@mattjennings
Copy link
Owner

awesome. This is the particular issue if you're curious, but vite-plugin-svelte will hopefully automate this soon as a temporary workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants