Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't transform flex-basis: 0 into flex-basis: 0% #368

Open
Golmote opened this issue Mar 30, 2021 · 0 comments
Open

Don't transform flex-basis: 0 into flex-basis: 0% #368

Golmote opened this issue Mar 30, 2021 · 0 comments

Comments

@Golmote
Copy link

Golmote commented Mar 30, 2021

Hello,

When given this code:

.foo {
    flex-basis: 0;
}

or this code:

.foo {
    flex-basis: 0px;
}

the minifier transform the value into 0%:

.foo{flex-basis:0%}

This is an issue because using percentages for flex-basis does not produce the same result.

This issue also happens when using the flex shorthand:

.foo {
    flex: 1 0 0;
}
.bar {
    flex: 1 0 0px;
}

gives

.foo{flex:1 0 0%}.bar{flex:1 0 0%}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant