calc() not followed by end of line or semicolon not correctly matched #301
Comments
davidscotson
pushed a commit
to davidscotson/minify
that referenced
this issue
Mar 22, 2020
It's not clear if both of these are necessary, the second one should just match everything the first one matches plus things within internal lines, so it seems redundant. The unit test commited with it, plus all the others still pass, and there's no diff in the output on a long test file.
davidscotson
pushed a commit
to davidscotson/minify
that referenced
this issue
Mar 22, 2020
It's not clear if both of these are necessary, the second one should just match everything the first one matches plus things within internal lines, so it seems redundant. The unit test commited with it, plus all the others still pass, and there's no diff in the output on a long test file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
calc() expressions not followed by end of line or semicolon are matched with the rest of the content on that line until the first semicolon. Sometimes this breaks the calc() expression like in the example below:
Original CSS:
.e-gallery-masonry .e-gallery-item { --percent-height: 0; position:absolute; width:calc(100% / var(--columns) - (var(--hgap) * (var(--columns) - 1) / var(--columns))); left:calc((100% / var(--columns) - (var(--hgap) * (var(--columns) - 1) / var(--columns))) * var(--column) + (var(--hgap) * var(--column))); top:calc(var(--percent-height) + (var(--row) * var(--vgap))) }Minified CSS:
.e-gallery-masonry .e-gallery-item{--percent-height:0;position:absolute;width:calc(100% / var(--columns) - (var(--hgap) * (var(--columns) - 1) / var(--columns)));left:calc((100% / var(--columns) - (var(--hgap) * (var(--columns) - 1) / var(--columns))) * var(--column) + (var(--hgap) * var(--column)));top:calc(var(--percent-height)+(var(--row) * var(--vgap)))}The problem is that there are no spaces around the last + (
...height)+(var(--row)...)The text was updated successfully, but these errors were encountered: