add ruby String to rust Byte Collection conversion #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i Added support for converting a ruby String into a rust byte collection
In ruby the main way to represent some bytes is with a string, (see File.read or Base64.strict_decode64). and the current way to accept such
a string with magnus is by receiving a RString and calling
.as\_slice().as\_vec()
which is unsafe, this creates safe interface to receive bytes from ruby.I've decided to use the Bytes crate since it seems to be rust communty's prefered way of dealing with collections of bytes and made the inclusion of it a non defaulted feature